iotjs: Add defconfigs for ARTIKS and doc #2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
1b9d3c8 to
4bded8b
Compare
|
Target : [4bded8bcd1d9fcb7d5976d895f9bfcb554238bde] - Code Rule Check (C++) OK. |
|
Target : [4bded8bcd1d9fcb7d5976d895f9bfcb554238bde] - Code Rule Check OK. |
| @@ -0,0 +1,150 @@ | |||
| ########################################################################### | |||
| # | |||
| # Copyright 2017 Samsung Electronics All Rights Reserved. | |||
| # | ||
| ########################################################################### | ||
| ############################################################################ | ||
| # configs/artik053s/nettest/Make.defs |
| @@ -0,0 +1,150 @@ | |||
| ########################################################################### | |||
| # | |||
| # Copyright 2017 Samsung Electronics All Rights Reserved. | |||
| # | ||
| ########################################################################### | ||
| ############################################################################ | ||
| # configs/artik055s/nettest/Make.defs |
docs/HowToUseIoTjs.md
Outdated
|
|
||
| ## Use reference configuration | ||
|
|
||
| machine=artik053 # Adapt with your supported target |
There was a problem hiding this comment.
If you want to change a line, you must add two spaces at end of line.
docs/HowToUseIoTjs.md
Outdated
| Using menuconfig an example can be used to selected needed feature. | ||
|
|
||
| make menuconfig | ||
| # Application Configuration ---> |
There was a problem hiding this comment.
Or 4 spaces,
It's will be properly formatted:
https://github.com/TizenTeam/TizenRT/blob/sandbox/rzr/review/master/docs/HowToUseIoTjs.md
and easier to read in editor or terminal.
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
4bded8b to
1ffd6d4
Compare
|
Target : [1ffd6d4cd68292cc610f2c98e39df3a66c5ced4f] - Code Rule Check (C++) OK. |
|
Target : [1ffd6d4cd68292cc610f2c98e39df3a66c5ced4f] - Code Rule Check OK. |
docs/HowToUseIoTjs.md
Outdated
| ## Use reference configuration | ||
|
|
||
| machine=artik053 # Adapt with your supported target | ||
| cd os && ./tools/configure.sh ${machine}/devel # Generate os/.config |
There was a problem hiding this comment.
What's the meaning of devel? not iotjs?
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
1ffd6d4 to
7f18e0b
Compare
|
Target : [7f18e0ba15dd70ccb449073863a0a7f80ac85b9a] - Code Rule Check (C++) OK. |
|
Target : [7f18e0ba15dd70ccb449073863a0a7f80ac85b9a] - Code Rule Check OK. |
| @@ -39,12 +39,14 @@ if EXAMPLES_IOTJS_STARTUP_WIFI | |||
| config EXAMPLES_IOTJS_STARTUP_WIFI_SSID | |||
| string "SSID of AP" | |||
| default "public" | |||
| depends on EXAMPLES_IOTJS_STARTUP_WIFI | |||
There was a problem hiding this comment.
I am sorry but last comment.
- If you intend to use
depends on EXAMPLES_IOTJS_STARTUP_WIFI, let's remove line 37.if EXAMPLES_IOTJS_STARTUP_WIFIand line 52,endif. That is duplicated with depends on. - If you want to keep
if xxinstead ofdepends on xx, you should move endif location to cover EXAMPLES_IOTJS_STARTUP_WIFI_AUTH and EXAMPLES_IOTJS_STARTUP_WIFI_CRYPTO.
Bug: Samsung#2009 Change-Id: I79e07b01dcd2a00883c83796ac9570f0e85c2545 Signed-off-by: Philippe Coval <[email protected]>
Some efforts to align configuration between targets: * iotjs_startup is enabled by default * ROM part is enabled to store javascripts in image * WiFi connection is disabled by default * DM, M2M is disabled to allow WiFi client feature * IPv6 Enabled to prevent libtuv build issues (resolved in later version) * ADC device enabled (for IoT.js adc module) Bug: Samsung#2009 Change-Id: Icbd2584daf98766185f5580a154d09589c77a9f6 Signed-off-by: Philippe Coval <[email protected]>
Bug: Samsung#2009 Change-Id: Ic6a9b78b69727f5937bb7f18a76036c626c7c5f5 Signed-off-by: Philippe Coval <[email protected]>
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
7f18e0b to
b83d0cd
Compare
|
Target : [b83d0cd] - Code Rule Check OK. |
|
Target : [b83d0cd] - Code Rule Check (C++) OK. |
sunghan-chang
approved these changes
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.