Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Incorrect duration with track containing multiple segments #209

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

gorgobacka
Copy link
Contributor

@gorgobacka gorgobacka commented Jul 6, 2022

While inspecting the gpx handling, I found a bug:
The variable stopped_time_between_seg contains only the time between the latest two segments and passes them to get_gpx_data.

This is not an issue, if the track contains only one or two segments. But if there are more, the additional calculations are incorrect.

The changed code aggregates the time between all segments now.

@SamR1
Copy link
Owner

SamR1 commented Jul 12, 2022

thanks for the fix.

@SamR1 SamR1 merged commit 048bad3 into SamR1:dev Jul 13, 2022
@gorgobacka
Copy link
Contributor Author

Thanks for adding a test case. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants