wlan_guide_settings api #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timvlaer and there are some lint issues see https://github.com/Salamek/huawei-lte-api/actions/runs/9963720492/job/27572212960?pr=219#step:5:19 |
|
Still some lint issues https://github.com/Salamek/huawei-lte-api/actions/runs/9989084977/job/27612359830?pr=219#step:5:60 and that print^ is still not replaced/removed... |
|
My bad @Salamek , thanks for checking. It should be good now 🤞 |
Salamek
approved these changes
Jul 20, 2024
huawei_lte_api/Session.py
Outdated
| @@ -32,10 +33,12 @@ def _try_or_reload_and_retry(fn: Callable[..., T]) -> Callable[..., T]: | |||
| def wrapped(*args: Any, **kw: Any) -> T: | |||
| try: | |||
| return fn(*args, **kw) | |||
| except ResponseErrorLoginCsrfException: | |||
| except ResponseErrorLoginCsrfException as e: | |||
| print("Retry because " + str(e)) | |||
There was a problem hiding this comment.
This should be _LOGGER.debug, _LOGGER.info or _LOGGER.warning so we do not pollute stdout with potentially unwanted text...
|
Looks good, merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, you find a script and some new functionality to the api to configure the Huawei 5576-320 as if you'd go through the setup webpage.
It does the same things as what you need to do manually but via the api:
I derived this information by reverse engineering the webpage hosted by the device.
I'll use a variant of this script to automatically configure our fleet of devices. The script still requires you to connect to the WiFi network of the device.
I hope this can help someone in the future.