Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(submenu): ensure submenu has expected width in Safari #7131

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nuria1110
Copy link
Contributor

@nuria1110 nuria1110 commented Dec 16, 2024

fix #7112

Proposed behaviour

MenuItem within a submenu extends to the expected width.

image

Current behaviour

MenuItem within a submenu with overflow gets cut off in Safari.

image

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

  • See added MenuItem in "submenus with long item labels" test story.

Copy link
Contributor

@edleeks87 edleeks87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we can go with this fix as if they haven't set the props on the MenuItem to adjust the width style properties (likely they won't) it looks like below

image

It does the same in both chrome and safari unfortunately

@edleeks87 edleeks87 marked this pull request as ready for review December 17, 2024 09:59
@edleeks87 edleeks87 requested review from a team as code owners December 17, 2024 09:59
@edleeks87 edleeks87 marked this pull request as draft December 17, 2024 09:59
Fixes issue where a MenuItem within a submenu with overflow would get cut off and render with a
scroll bar.

fix #7112
@edleeks87 edleeks87 marked this pull request as ready for review December 17, 2024 16:48
@edleeks87 edleeks87 marked this pull request as draft December 17, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

submenu overflow on Safari
2 participants