Select virtualiser tweaks #7001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edleeks87
force-pushed
the
select-virtualiser-tweaks
branch
from
47091dc to
69a086d
Compare
Parsium
reviewed
Oct 7, 2024
nineteen88
reviewed
Oct 8, 2024
nineteen88
reviewed
Oct 8, 2024
edleeks87
force-pushed
the
select-virtualiser-tweaks
branch
from
69a086d to
790f388
Compare
Parsium
previously approved these changes
Oct 8, 2024
nineteen88
previously approved these changes
Oct 9, 2024
edleeks87
force-pushed
the
select-virtualiser-tweaks
branch
from
790f388 to
8eaded4
Compare
Parsium
approved these changes
Oct 9, 2024
Parsium
previously approved these changes
Oct 9, 2024
dariusbercea-sage
previously approved these changes
Oct 14, 2024
Upgrades `@tanstack/react-virtual` to 3.10.8 fix #6978
Updates Option interface to allow `value` and `text` to be optional to allow users to compose `children` for complex layouts. This ensures that `SelectList` height is set relatively when a custom option is passed as child so that there is no overflow fix #6939
edleeks87
force-pushed
the
select-virtualiser-tweaks
branch
from
8eaded4 to
fb37215
Compare
dariusbercea-sage
approved these changes
Oct 14, 2024
Parsium
approved these changes
Oct 14, 2024
nineteen88
approved these changes
Oct 14, 2024
|
🎉 This PR is included in version 143.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
edleeks87
added a commit
that referenced
this pull request
Oct 14, 2024
…` is an empty string Adds invariant to ensure that the component does not render when `children` are passed but `submenu` is an empty string fix #7001
edleeks87
added a commit
that referenced
this pull request
Oct 14, 2024
…` is an empty string Adds invariant to ensure that the component does not render when `children` are passed but `submenu` is an empty string fix #7001
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6978
fix #6939
Proposed behaviour
Upgrades
@tanstack/react-virtualto3.10.8Updates
Optioninterface to allowvalueandtextto be optional to allow users to composechildrenfor complex layouts. This ensures thatSelectListheight is set relatively when a custom option is passed as child so that there is no overflow (scrollbars). When no value is passed the option is treated as non-interactive (can't be clicked or selected) and is styled as such.Current behaviour
@tanstack/react-virtualis3.0.0-beta.68Option requires
valueandtextto be setChecklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions