Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: basic structure for implementation of tabular containers with polars #731

Merged
merged 16 commits into from
May 6, 2024

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented May 6, 2024

Closes partially #712

Summary of Changes

Add (mostly empty) classes for a new implementation of the tabular containers with polars.

Copy link
Contributor

github-actions bot commented May 6, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 17 0 0 0.88s
✅ PYTHON mypy 17 0 2.18s
✅ PYTHON ruff 17 0 0 0.23s
✅ REPOSITORY git_diff yes no 0.22s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cd7f55b) to head (f9a74db).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #731   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           66        67    +1     
  Lines         4873      4875    +2     
=========================================
+ Hits          4873      4875    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Marsmaennchen221 and others added 3 commits May 6, 2024 17:36
…up to 2 (#697)

### Summary of Changes

perf: improved performance of `TabularDataset.__eq__` by a factor of up
to 2
perf: slightly improved performance of `TabularDataset.__hash__`
fix: corrected `TabularDataset.__sizeof__`

---------

Co-authored-by: megalinter-bot <[email protected]>
@lars-reimann lars-reimann marked this pull request as ready for review May 6, 2024 16:03
@lars-reimann lars-reimann requested a review from a team as a code owner May 6, 2024 16:03
@lars-reimann lars-reimann merged commit 3261b26 into main May 6, 2024
10 checks passed
@lars-reimann lars-reimann deleted the polars branch May 6, 2024 16:04
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants