Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add find_edges method in Image #523

Closed
Marsmaennchen221 opened this issue Jan 10, 2024 · 1 comment · Fixed by #531
Closed

Add find_edges method in Image #523

Marsmaennchen221 opened this issue Jan 10, 2024 · 1 comment · Fixed by #531
Assignees
@Marsmaennchen221
Labels
enhancement 💡 New feature or request released Included in a release

Comments

@Marsmaennchen221
Copy link
Contributor

Is your feature request related to a problem?

The Image Class prior to #506 had a find_edges method, which we removed because PyTorch has no such method.

Desired solution

Implement a method with that functionality, or implement a pre-trained NN.

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response
@Marsmaennchen221 Marsmaennchen221 added the enhancement 💡 New feature or request label Jan 10, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Library Jan 10, 2024
@Marsmaennchen221 Marsmaennchen221 mentioned this issue Jan 10, 2024
Merged
@Marsmaennchen221 Marsmaennchen221 self-assigned this Jan 18, 2024
@Marsmaennchen221 Marsmaennchen221 mentioned this issue Jan 19, 2024
Merged
@Marsmaennchen221 Marsmaennchen221 linked a pull request Jan 19, 2024 that will close this issue
feat: Add find_edges method in Image #531
Merged
lars-reimann pushed a commit that referenced this issue Jan 21, 2024
@Marsmaennchen221 @megalinter-bot
feat: Add find_edges method in Image (#531)
d728eb6 
Closes #523 

### Summary of Changes

Added find_edges method for the new image class. Works just like the
find_edges method from the old Image class with pillow.
Fixed images with one channel for both repr and both to_file methods.
Added grayscale images that only contain one channel each.
Re-enabled Image.adjust_color_balance & Image.find_edges in the Image
tutorial.
Added warning for adjust_color_balance if it is used on a grayscale
image.

---------

Co-authored-by: megalinter-bot <[email protected]>
@github-project-automation github-project-automation bot moved this from Backlog to ✔️ Done in Library Jan 21, 2024
lars-reimann pushed a commit that referenced this issue Feb 3, 2024
@semantic-release-bot
chore(release): 0.18.0 [skip ci]
32b4d8f 
## [0.18.0](v0.17.1...v0.18.0) (2024-02-03)

### Features

* Add adjust_color_balance method in Image ([#530](#530)) ([dba23f9](dba23f9)), closes [#525](#525)
* Add find_edges method in Image ([#531](#531)) ([d728eb6](d728eb6)), closes [#523](#523)
* class for time series ([#508](#508)) ([73cdfb1](73cdfb1)), closes [#481](#481)
@lars-reimann
Copy link
Member

🎉 This issue has been resolved in version 0.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Marsmaennchen221 Marsmaennchen221

Labels
enhancement 💡 New feature or request released Included in a release
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add find_edges method in Image Safe-DS/Library
2 participants
@lars-reimann @Marsmaennchen221