This repository has been archived by the owner on Nov 23, 2024. It is now read-only.
feat: extracting valid literals from documentation #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on string and the type string of a parameter
The pattern execution configuration was added.
…test_extract_valid_literals.py' Refactored the configurations in '_extract_valid_values.py' dicts -> dataclasses Deleted 'parameter_data_with_dscription.json'
nvollroth
changed the title
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov Report
@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 89.76% 89.96% +0.19%
==========================================
Files 83 84 +1
Lines 3998 4075 +77
==========================================
+ Hits 3589 3666 +77
Misses 409 409
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lukarade
reviewed
Mar 31, 2023
tests/library_analyzer/processing/annotations/test_extract_valid_literals.py
Outdated
Show resolved
Hide resolved
lukarade
reviewed
Mar 31, 2023
…n' into 46-multi-part-enumtype-extraction
New recognition pattern for the description string was added Detection of legal values is now interrupted only if the detection within the type string resulted in a hit.
…n' into 46-multi-part-enumtype-extraction
…e as valid values when a boolean is detected. In addition, the system checks whether there are matching string values in the description that are not True, False or None if 'str' is set in the type string. If this is not the case, 'unlistable_str' is returned. The test cases have been adapted accordingly.
lars-reimann
reviewed
Apr 3, 2023
lars-reimann
changed the title
lars-reimann
approved these changes
Apr 3, 2023
|
Feel free to merge this if you're done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #46.
Summary of Changes
Currently, valid values for the enum annotations were determined only via the type string. In order to achieve a higher recognition rate of the enum annotations, the recognition of the valid values was extended to the description.
Testing Instructions
pytestfortest_extract_valid_literals.py.pytest.