first commit of supporting zext and sext #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1398 +/- ##
==========================================
+ Coverage 67.80% 68.09% +0.29%
==========================================
Files 250 250
Lines 27612 27770 +158
==========================================
+ Hits 18721 18909 +188
+ Misses 8891 8861 -30
|
yuleisui
reviewed
Mar 8, 2024
svf-llvm/lib/SVFIRBuilder.cpp
Outdated
| else if (SVFUtil::isa<llvm::SExtInst>(&inst)) | ||
| { | ||
| addCopyEdge(src, dst, CopyStmt::SEXT); | ||
| } |
There was a problem hiding this comment.
try to list all other types here
yuleisui
reviewed
Mar 8, 2024
svf/lib/SVFIR/SVFIR.cpp
Outdated
| @@ -75,6 +74,10 @@ CopyStmt* SVFIR::addCopyStmt(NodeID src, NodeID dst) | |||
| return copyPE; | |||
| } | |||
| } | |||
| CopyStmt* SVFIR::addCopyStmt(NodeID src, NodeID dst) | |||
There was a problem hiding this comment.
We don't need this method?
yuleisui
reviewed
Mar 8, 2024
svf-llvm/lib/SVFIRBuilder.cpp
Outdated
| @@ -743,7 +743,19 @@ void SVFIRBuilder::visitCastInst(CastInst &inst) | |||
| opnd = stripAllCasts(opnd); | |||
|
|
|||
| NodeID src = getValueNode(opnd); | |||
| addCopyEdge(src, dst); | |||
| // if ZEXT | |||
| if(SVFUtil::isa<llvm::ZExtInst>(&inst)) | |||
There was a problem hiding this comment.
try to find all other invocation sites that calls addCopyEdge., like processCE, InitialGlobal, visitVAArgInst, visitFreezeInst, handleExtCall
yuleisui
reviewed
Mar 15, 2024
| if (_es[var->getId()].is_numeral()) { | ||
| if (bits == 8) { | ||
| int8_t signed_i8_value = _es[var->getId()].getIntNumeral(); | ||
| uint32_t unsigned_value = static_cast<uint8_t>(signed_i8_value); |
yuleisui
reviewed
Mar 15, 2024
| return IntervalValue(unsigned_value, unsigned_value); | ||
| } | ||
| else if (bits == 16) { | ||
| int16_t signed_i16_value = _es[var->getId()].getIntNumeral(); |
yuleisui
reviewed
Mar 15, 2024
| else if (copy->getCopyKind() == CopyStmt::FPTRUNC) { | ||
| _es[lhs] = getFPTruncValue(copy->getRHSVar(), copy->getLHSVar()->getType()); | ||
| } | ||
|
|
yuleisui
reviewed
Mar 15, 2024
| return CopyStmt::COPYVAL; | ||
| } | ||
| } | ||
| return CopyStmt::UNKNOWN; |
There was a problem hiding this comment.
Do we have UNKNOWN? What is this for?
yuleisui
reviewed
Mar 15, 2024
| @@ -401,7 +401,7 @@ class SVFIRBuilder: public llvm::InstVisitor<SVFIRBuilder> | |||
| return CopyStmt::COPYVAL; | |||
| } | |||
| } | |||
| return CopyStmt::UNKNOWN; | |||
| assert (false && "Unknown cast inst!"); | |||
yuleisui
reviewed
Mar 15, 2024
| _es[lhs] = _es[rhs]; | ||
| if (copy->getCopyKind() == CopyStmt::COPYVAL) { | ||
| _es[lhs] = _es[rhs]; | ||
| } | ||
| if (copy->getCopyKind() == CopyStmt::ZEXT) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.