Add Memory Statistics and Clean Solitaries in Constraint Graph #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuleisui
reviewed
Jan 20, 2024
svf/lib/WPA/Andersen.cpp
Outdated
Comment on lines
80
to
83
| u32_t vmrss = 0; | ||
| u32_t vmsize = 0; | ||
| SVFUtil::getMemoryUsageKB(&vmrss, &vmsize); | ||
| stat->setMemUsageBefore(vmrss, vmsize); |
There was a problem hiding this comment.
move this to PTAState's constructor.
yuleisui
reviewed
Jan 20, 2024
svf/lib/WPA/Andersen.cpp
Outdated
Comment on lines
104
to
107
| u32_t vmrss = 0; | ||
| u32_t vmsize = 0; | ||
| SVFUtil::getMemoryUsageKB(&vmrss, &vmsize); | ||
| stat->setMemUsageAfter(vmrss, vmsize); |
There was a problem hiding this comment.
move to PTAStat::performStat()
yuleisui
reviewed
Jan 20, 2024
Comment on lines
+355
to
+356
| PTNumStatMap["MemoryUsageVmrss"] = _vmrssUsageAfter - _vmrssUsageBefore; | ||
| PTNumStatMap["MemoryUsageVmsize"] = _vmsizeUsageAfter - _vmsizeUsageBefore; |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1340 +/- ##
==========================================
+ Coverage 65.69% 65.73% +0.03%
==========================================
Files 226 225 -1
Lines 24215 24242 +27
==========================================
+ Hits 15908 15935 +27
Misses 8307 8307
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown in the above graph, in this patch,