opaque pointer stage 2-1 #1304
opaque pointer stage 2-1 #1304
Conversation
| } | ||
| else | ||
| { | ||
| assert(false && (LLVMUtil::dumpValue(value) + "Unknown llvm Type, cannot get Ptr Element Type").c_str()); |
There was a problem hiding this comment.
better to dump this unknown value.
svf-llvm/lib/SymbolTableBuilder.cpp
Outdated
| { | ||
| // collect object type in instructions (alloc, heap) and globals | ||
| if (LLVMUtil::isObject(val)) { | ||
| const Type *objtype = LLVMUtil::getPointeeType(val); |
There was a problem hiding this comment.
would void* x = malloc() work here?
There was a problem hiding this comment.
Object type has to be inferred here?
There was a problem hiding this comment.
Object type has to be inferred here?
I agree. For malloc site, this should be done after inferring malloc type. For other types, it is ok to collect here.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1304 +/- ##
==========================================
+ Coverage 64.61% 64.64% +0.02%
==========================================
Files 225 225
Lines 23892 23875 -17
==========================================
- Hits 15438 15434 -4
+ Misses 8454 8441 -13
|
svf-llvm/lib/SymbolTableBuilder.cpp
Outdated
| @@ -590,8 +592,8 @@ ObjTypeInfo* SymbolTableBuilder::createObjTypeInfo(const Value* val) | |||
| // (2) Other objects (e.g., alloca, global, etc.) | |||
| else | |||
| { | |||
| if(const PointerType* refTy = SVFUtil::dyn_cast<PointerType>(val->getType())) | |||
| objTy = getPtrElementType(refTy); | |||
| if(SVFUtil::isa<PointerType>(val->getType())) | |||
There was a problem hiding this comment.
It looks to me that this pointee type has to be inferred if this val is an object from a malloc site.
There was a problem hiding this comment.
It looks to me that this pointee type has to be inferred if this val is an object from a malloc site.
This branch cannot be a malloc site. The object is alloca, global, etc. The malloc site is not yet done (to be done in inferTypeOfHeapObjOrStaticObj).
| @@ -598,6 +590,8 @@ ObjTypeInfo* SymbolTableBuilder::createObjTypeInfo(const Value* val) | |||
|
|
|||
| if (objTy) | |||
| { | |||
| // collect object type information | |||
| (void) getOrAddSVFTypeInfo(objTy); | |||
There was a problem hiding this comment.
should return an SVFType ad use it at line 596.
jumormt
force-pushed
the
opaque
branch
3 times, most recently
from
c889648 to
eb941d8
Compare
infer object type based on instructions or globals