fix getByteOffsets in GepStmt and SVFIR2ItvExeState #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bjjwwang
commented
Nov 7, 2023
bjjwwang
commented
- add getLLVMByteSize in SVFType
- fix getByteOffset in SVFIR2ExeState and GepStmt
yuleisui
reviewed
Nov 7, 2023
svf/lib/SVFIR/SVFType.cpp
Outdated
| @@ -4,6 +4,11 @@ | |||
| namespace SVF | |||
| { | |||
|
|
|||
| __attribute__((weak)) | |||
| u32_t SVFType::getLLVMByteSize() const { | |||
| return 0; | |||
There was a problem hiding this comment.
Put an assertion to mention implementation and add an abort() method. See SVFValue::toString()
yuleisui
reviewed
Nov 7, 2023
| /// e.g. GepStmt* gep = [i32*4]*, 2 | ||
| /// APOffset byteOffset = gep->accumulateConstantByteOffset(); | ||
| /// byteOffset should be 8 since i32 is 4 bytes and index is 2. | ||
| APOffset computeConstantByteOffset() const; |
There was a problem hiding this comment.
Need to explain a bit more about this method since the argument has been removed.
There was a problem hiding this comment.
I guess the argument is no longer needed.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1240 +/- ##
==========================================
- Coverage 64.49% 64.48% -0.02%
==========================================
Files 223 223
Lines 23669 23674 +5
==========================================
Hits 15266 15266
- Misses 8403 8408 +5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.