-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Celestica]: Add support for Blackstone platform #262
[Celestica]: Add support for Blackstone platform #262
Conversation
…ytest (sonic-net#7431) Co-authored-by: Shi Lei <[email protected]>
…v-switch-driver [device/celestica-blackstone]: Update switch CPLD driver follow FPGA i2c buses
This reverts commit c133492.
This reverts commit 318b145.
device/celestica/x86_64-cel_blackstone-r0/sonic_platform/chassis.py
Outdated
Show resolved
Hide resolved
device/celestica/x86_64-cel_blackstone-r0/sonic_platform/chassis.py
Outdated
Show resolved
Hide resolved
device/celestica/x86_64-cel_blackstone-r0/sonic_platform/chassis.py
Outdated
Show resolved
Hide resolved
* [platform/cel-blackstone]: update misc_cpld device name * [platform/cel-blackstone]: update misc_cpld driver version * [platform/cel-blackstone]: update misc_cpld init command
* [platform/cel-blackstone]: update FPGA driver to support BMC I2C * [platform/cel-blackstone]: update i2c devices driver init command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As commented.
If possible, please apply Linux kernel codes style to the source files under blackstone/modules/ path.
static void fpga_pci_remove(void) | ||
{ | ||
iounmap(fpga_dev.data_base_addr); | ||
// class_unregister(fpgafwclass); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this unused codes be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will remove next release
|
||
if (dev){ | ||
err = fpga_pci_probe(dev); | ||
// pci_dev_put(dev); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will remove next release
@@ -0,0 +1,846 @@ | |||
// SPDX-License-Identifier: GPL-2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we using the ocores-i2c
from the kernel source tree, could this module and the i2c-ocores.h be removed from the platform-specific path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will remove next release
* [device/celestica-blackstone]: update necessary chassis apis * [platform/cel-blackstone]: add platform api installer * [platform/cel]: update missing apis installer command * [device/celestica-blackstone]: update sfputil follow hw spec * [device/celestica-blackstone]: update skip_syseepromd config for pmon
* [device/celestica-blackstone]: update necessary chassis apis * [platform/cel-blackstone]: add platform api installer * [platform/cel]: update missing apis installer command * [device/celestica-blackstone]: update sfputil follow hw spec * [device/celestica-blackstone]: update skip_syseepromd config for pmon * [platform/cel]: update api installer script
- What I did
- How I did it
- How to verify it
- Note