Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply clock drift to SubjectConfirmationData and AuthnStatement #385

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Apply clock drift to SubjectConfirmationData and AuthnStatement #385

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c66eef9
Apply clock drift to SubjectConfirmationData
tvuotila Oct 24, 2023
b8a0225
Apply clock drift to AuthnStatement
tvuotila Oct 25, 2023
e41f31c
Merge branch 'SAML-Toolkits:master' into feature/apply-clock-drift-to…
tvuotila Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/onelogin/saml2/response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ def is_valid(self, request_data, request_id=None, raise_exceptions=False):

# Checks the session Expiration
session_expiration = self.get_session_not_on_or_after()
if session_expiration and session_expiration <= OneLogin_Saml2_Utils.now():
if session_expiration and session_expiration + OneLogin_Saml2_Constants.ALLOWED_CLOCK_DRIFT <= OneLogin_Saml2_Utils.now():
raise OneLogin_Saml2_ValidationError(
"The attributes have expired, based on the SessionNotOnOrAfter of the AttributeStatement of this Response", OneLogin_Saml2_ValidationError.SESSION_EXPIRED
)
Expand All @@ -206,12 +206,12 @@ def is_valid(self, request_data, request_id=None, raise_exceptions=False):
nooa = sc_data.get("NotOnOrAfter", None)
if nooa:
parsed_nooa = OneLogin_Saml2_Utils.parse_SAML_to_time(nooa)
if parsed_nooa <= OneLogin_Saml2_Utils.now():
if parsed_nooa + OneLogin_Saml2_Constants.ALLOWED_CLOCK_DRIFT <= OneLogin_Saml2_Utils.now():
continue
nb = sc_data.get("NotBefore", None)
if nb:
parsed_nb = OneLogin_Saml2_Utils.parse_SAML_to_time(nb)
if parsed_nb > OneLogin_Saml2_Utils.now():
if parsed_nb > OneLogin_Saml2_Utils.now() + OneLogin_Saml2_Constants.ALLOWED_CLOCK_DRIFT:
continue

if nooa:
Expand Down
Loading