Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP unit fixes #472

Merged
merged 4 commits into from
Jun 29, 2021
Merged

PHP unit fixes #472

merged 4 commits into from
Jun 29, 2021

Conversation

Fredthelead
Copy link

  • Added a try-catch clause in Utils.php and return false if feeded with bad XML - as dictated in the phpunit test.
  • Fixed some typos where the scalar value false was misspelled.
  • Replaced assertNotContains with assertStringNotContainsString when asserting strings.

@pitbulk
Copy link
Contributor

pitbulk commented Apr 30, 2021

Hi, @Fredrik82

I think the loadXML method should raise an exception if not able to load the XML.

@Fredthelead
Copy link
Author

Hi, @Fredrik82

I think the loadXML method should raise an exception if not able to load the XML.

I agree. I was unsure if the unit-test was supposed to be considered as source of truth or not. I reverted that commit and added a try-catch in the unit test instead.

@pitbulk pitbulk merged commit f884f64 into SAML-Toolkits:4.0.0 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants