Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request intends to add support for HTTP-POST binding for login and logout operations. However, it is not completed yet. It still misses:
Before I spend more time implementing the missing parts, I want to check with you @pitbulk if it is OK to add support for HTTP-POST binding to this library.
I found another Pull request where this discussion has been made and I'm not sure what your plans are regarding the HTTP-POST binding.
Should I finish implementing this? Or this is a feature that you don't want to support at all?
If you want me to finish it, please take a quick lock on the current changes to validate my approach, so I can adjust anything.
Thank you,
Samuel Campos