Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for HTTP-POST binding #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samuelcampos
Copy link
Contributor

This pull request intends to add support for HTTP-POST binding for login and logout operations. However, it is not completed yet. It still misses:

  • Support logout with HTTP-POST binding
  • Unit tests

Before I spend more time implementing the missing parts, I want to check with you @pitbulk if it is OK to add support for HTTP-POST binding to this library.
I found another Pull request where this discussion has been made and I'm not sure what your plans are regarding the HTTP-POST binding.

Should I finish implementing this? Or this is a feature that you don't want to support at all?
If you want me to finish it, please take a quick lock on the current changes to validate my approach, so I can adjust anything.

Thank you,
Samuel Campos

@coveralls
Copy link

coveralls commented Jan 24, 2018

Coverage Status

Coverage decreased (-2.6%) to 92.656% when pulling 6d95d4d on samuelcampos:master into 94b3ed8 on onelogin:master.

@pitbulk
Copy link
Contributor

pitbulk commented Jan 24, 2018

I don't have plans to officially support and maintain HTTP-POST binding for AuthNRequest (sent), LogoutRequest(sent and receive) and LogoutResponse(sent and receive).

I'm ok to merge reasonable changes on the core component, as the one you did on addSign, to make easier that feature, and keep them on the master branch, but changes on the toolkit component as you did will not be included on master branch.

I can offer to you the same solution that offered at the php-saml toolkit.

@samuelcampos
Copy link
Contributor Author

Thank you for the transparency regarding your plans for this library.
I'll continue to implement support for HTTP-POST binding on my spare time and, at the end, I'll decide if it is reasonable to maintain the required changes on a separated branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants