Article about Feliz and Fable React #350
Conversation
There was a problem hiding this comment.
The content is globally correct I would just avoid using invalid code snippets because this can be confusing to the users.
Regarding Feliz syntax, I believe most people/documentation use the prefixed DSL Html.div instead of div. So I am not sure we should use the non-prefixed version.
Or if we should use the prefixed version and then add a note about the non-prefixed version and how to activate it.
I also believe that the non prefixed version is not allows possible to user with binding library like Feliz.Bulma because it use a mix of static member and modules.
Lastly, it could perhaps be interesting to linked My journey with Feliz | A comparison between Fable.React and Feliz which goes much more in details and contains feedbacks/remarks from the community.
docs/faq/faq-felizandfable.md
Outdated
| ```fsharp | ||
| h1 [ | ||
| style "color:Tomato" | ||
| children [ | ||
| p [ text "Hello" ] | ||
| p [ text "Another paragraph" ] | ||
| h2 [ style "color:Blue" ] | ||
| ] | ||
| ] | ||
| ``` |
There was a problem hiding this comment.
Same here.
h1 [
className "primary"
children [
p [ text "Hello" ]
p [ text "Another paragraph" ]
h2 [ className "primary" ]
]
]Code is valid if users use
open type Feliz.Html open type Feliz.prop
|
@MangelMaxime could you re-review this to see if it's now ready to go in? |
|
@isaacabraham I added a few more comments. The first one is the problematic one the others two are more related to details that you can decide to follow or not. |
|
@isaacabraham ping |
|
I'll fix this tomorrow |
|
@mattgallagher92 I addressed the last few open issues. Ok to merge? |
There was a problem hiding this comment.
@Larocceau yep, though I'd just make one slight wording change 🙂
| @@ -68,6 +64,7 @@ Html.h1 [ // this is now fine | |||
| ## Guidance | |||
| * Fable.React was created initially, whilst Feliz was developed some time later. | |||
| * Feliz has better support for React interop and the majority of the community nowadays uses the Feliz DSL style for developing components. | |||
| * As they are both wrappers around the same underlying technology (React) and Feliz uses some parts of Fable.React, you can actually mix and match the two in your applications as required. | |||
| * Fable.React and Feliz can be mixed into your application if required (for progressive migration for example) | |||
There was a problem hiding this comment.
| * Fable.React and Feliz can be mixed into your application if required (for progressive migration for example) | |
| * Fable.React and Feliz can be mixed together in your application if required (for progressive migration for example) |
"Mixed into" doesn't necessarily imply mixed together, so I'd make this clearer.
@MangelMaxime can you have a quick look through this article just to make sure it's broadly correct?
Thanks