Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove argo configuration requirements - RK-19033 #55

Merged
merged 1 commit into from
Jun 27, 2023
Merged

fix: remove argo configuration requirements - RK-19033 #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/conf/workflow_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import (
)

type WorkflowServerConfig struct {
ArgoToken string `envconfig:"ARGO_WORKFLOWS_TOKEN" required:"true"`
ArgoAddress string `envconfig:"ARGO_WORKFLOWS_ADDRESS" required:"true"`
ArgoToken string `envconfig:"ARGO_WORKFLOWS_TOKEN" required:"false"`
ArgoAddress string `envconfig:"ARGO_WORKFLOWS_ADDRESS" required:"false"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What address means? Ip ? Url ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how ever piper will talk to argo workflows server.
It could be IP, External URL, Internal URL ( internal K8s DNS )

CreateCRD bool `envconfig:"ARGO_WORKFLOWS_CREATE_CRD" default:"true"`
Namespace string `envconfig:"ARGO_WORKFLOWS_NAMESPACE" default:"default"`
KubeConfig string `envconfig:"KUBE_CONFIG" default:""`
Expand Down