fix: remove argo configuration requirements - RK-19033 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gosha <[email protected]>
|
Github Enforcer opened Task: RK-19033 |
sonariorobot
changed the title
gosharo
changed the title
qadiludmer
reviewed
Jun 23, 2023
| ArgoToken string `envconfig:"ARGO_WORKFLOWS_TOKEN" required:"true"` | ||
| ArgoAddress string `envconfig:"ARGO_WORKFLOWS_ADDRESS" required:"true"` | ||
| ArgoToken string `envconfig:"ARGO_WORKFLOWS_TOKEN" required:"false"` | ||
| ArgoAddress string `envconfig:"ARGO_WORKFLOWS_ADDRESS" required:"false"` |
There was a problem hiding this comment.
What address means? Ip ? Url ?
There was a problem hiding this comment.
how ever piper will talk to argo workflows server.
It could be IP, External URL, Internal URL ( internal K8s DNS )
alexeygutkin
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gosha [email protected]
Pull Request
Description
Please provide a brief description of the changes made in this pull request.
Related Issue(s)
If this pull request addresses or relates to any open issues, please mention them here using the syntax
Fixes #<issue_number>orResolves #<issue_number>.Checklist
Before submitting this pull request, please ensure that you have completed the following tasks:
Testing Instructions
Please provide clear instructions on how to test and verify the changes made in this pull request.
Additional Information
Add any additional information or context that would be helpful in understanding and reviewing this pull request.