Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: old omnichannel rooms only being migrated after their data is loaded by the client #34090

Merged

Conversation

pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Nov 29, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

SCI-190

We no longer use contacts.get using the visitor association as parameter, only using the contactId; Since this endpoint was introduced on this same release, we've removed the option of using the visitor altogether with no risk of breaking anything.

Copy link
Contributor

dionisio-bot bot commented Nov 29, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 29, 2024

⚠️ No Changeset found

Latest commit: 3f580f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.75%. Comparing base (5b4ed31) to head (3f580f8).
Report is 1 commits behind head on release-7.1.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.1.0   #34090   +/-   ##
==============================================
  Coverage          75.75%   75.75%           
==============================================
  Files                510      510           
  Lines              22078    22078           
  Branches            5387     5387           
==============================================
  Hits               16726    16726           
  Misses              4706     4706           
  Partials             646      646           
Flag Coverage Δ
unit 75.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

github-actions bot commented Nov 29, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34090/
on branch gh-pages at 2024-11-29 17:56 UTC

@dougfabris dougfabris added this to the 7.1.0 milestone Nov 29, 2024
@dougfabris dougfabris changed the base branch from develop to release-7.1.0 November 29, 2024 17:36
…a is loaded by the client, causing it to not have the ContactId available
@dougfabris dougfabris changed the base branch from release-7.1.0 to develop November 29, 2024 17:38
@dougfabris dougfabris changed the base branch from develop to release-7.1.0 November 29, 2024 17:39
@dougfabris dougfabris force-pushed the regression/contact-id-missing-from-room-data branch from 70e4f6f to ac9e63c Compare November 29, 2024 17:39
@dougfabris dougfabris marked this pull request as ready for review November 29, 2024 19:55
@dougfabris dougfabris requested review from a team as code owners November 29, 2024 19:55
Copy link
Contributor

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if ci happy me happy

@renatobecker renatobecker added the stat: QA assured Means it has been tested and approved by a company insider label Dec 2, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 2, 2024
@kodiakhq kodiakhq bot merged commit a33b209 into release-7.1.0 Dec 2, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the regression/contact-id-missing-from-room-data branch December 2, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants