regression: lastChat property missing on contact migrated from visi…

…tor (#34016)
RocketChat · Nov 21, 2024 · 31362ac · 31362ac
1 parent 5b01136
commit 31362ac
Show file tree

Hide file tree

Showing 3 changed files with 48 additions and 1 deletion.
diff --git a/apps/meteor/app/livechat/server/lib/contacts/createContact.ts b/apps/meteor/app/livechat/server/lib/contacts/createContact.ts
@@ -1,4 +1,4 @@
-import type { ILivechatContactChannel } from '@rocket.chat/core-typings';
+import type { ILivechatContactChannel, IVisitorLastChat } from '@rocket.chat/core-typings';
 import { LivechatContacts } from '@rocket.chat/models';
 
 import { getAllowedCustomFields } from './getAllowedCustomFields';
@@ -11,6 +11,7 @@ export type CreateContactParams = {
 	phones?: string[];
 	unknown: boolean;
 	customFields?: Record<string, string | unknown>;
+	lastChat?: IVisitorLastChat;
 	contactManager?: string;
 	channels?: ILivechatContactChannel[];
 	importIds?: string[];
@@ -21,6 +22,7 @@ export async function createContact({
 	emails,
 	phones,
 	customFields: receivedCustomFields = {},
+	lastChat,
 	contactManager,
 	channels = [],
 	unknown,
@@ -40,6 +42,7 @@ export async function createContact({
 		contactManager,
 		channels,
 		customFields,
+		lastChat,
 		unknown,
 		...(importIds?.length && { importIds }),
 	});

diff --git a/apps/meteor/app/livechat/server/lib/contacts/mapVisitorToContact.spec.ts b/apps/meteor/app/livechat/server/lib/contacts/mapVisitorToContact.spec.ts
@@ -13,6 +13,7 @@ const { mapVisitorToContact } = proxyquire.noCallThru().load('./mapVisitorToCont
 	},
 });
 
+const testDate = new Date();
 const dataMap: [Partial<ILivechatVisitor>, IOmnichannelSource, CreateContactParams][] = [
 	[
 		{
@@ -87,6 +88,48 @@ const dataMap: [Partial<ILivechatVisitor>, IOmnichannelSource, CreateContactPara
 			contactManager: undefined,
 		},
 	],
+
+	[
+		{
+			_id: 'visitor1',
+			username: 'Username',
+			lastChat: {
+				_id: 'last-chat-id',
+				ts: testDate,
+			},
+		},
+		{
+			type: OmnichannelSourceType.WIDGET,
+		},
+		{
+			name: 'Username',
+			emails: undefined,
+			phones: undefined,
+			unknown: false,
+			channels: [
+				{
+					name: 'sms',
+					visitor: {
+						visitorId: 'visitor1',
+						source: {
+							type: OmnichannelSourceType.WIDGET,
+						},
+					},
+					blocked: false,
+					verified: false,
+					details: {
+						type: OmnichannelSourceType.WIDGET,
+					},
+				},
+			],
+			customFields: undefined,
+			lastChat: {
+				_id: 'last-chat-id',
+				ts: testDate,
+			},
+			contactManager: undefined,
+		},
+	],
 ];
 
 describe('mapVisitorToContact', () => {

diff --git a/apps/meteor/app/livechat/server/lib/contacts/mapVisitorToContact.ts b/apps/meteor/app/livechat/server/lib/contacts/mapVisitorToContact.ts
@@ -25,6 +25,7 @@ export async function mapVisitorToContact(visitor: ILivechatVisitor, source: IOm
 			},
 		],
 		customFields: visitor.livechatData,
+		lastChat: visitor.lastChat,
 		contactManager: visitor.contactManager?.username && (await getContactManagerIdByUsername(visitor.contactManager.username)),
 	};
 }