Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to bluesky-social/react-native-bottom-sheet #5769

Merged
merged 6 commits into from
Jul 8, 2024

Conversation

dnlsilva
Copy link
Contributor

@dnlsilva dnlsilva commented Jul 4, 2024

Proposed changes

Currently the library used does not correctly support accessibility, migration is necessary to support accessibility of the mobile app.

Issue(s)

related:
gorhom/react-native-bottom-sheet#1311
gorhom/react-native-bottom-sheet#1288

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Jira: MA-1

@dnlsilva dnlsilva merged commit 1c540ad into develop Jul 8, 2024
3 of 8 checks passed
@dnlsilva dnlsilva deleted the fix-action-sheet-acessibility branch July 8, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants