Feature/allow disabling daemon logs #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelgruner
requested review from
mmontero,
lleon95,
emmadrigal and
jcaballeros
lleon95
requested changes
Mar 11, 2022
| @@ -100,6 +101,10 @@ main (gint argc, gchar * argv[]) | |||
| {"gst-log-filename", 'd', 0, G_OPTION_ARG_FILENAME, &gstlogfile, | |||
| "Create gst.log file to path", NULL} | |||
| , | |||
| {"no-log", 'L', 0, G_OPTION_ARG_NONE, &nolog, | |||
There was a problem hiding this comment.
-L for the option of disabling the logging is counter-intuitive. Should we add the boolean as an argument and make it enabled by default?
gstd/gstd.c
Outdated
| @@ -128,7 +133,7 @@ main (gint argc, gchar * argv[]) | |||
| } | |||
|
|
|||
| if (daemon || kill) { | |||
| if (!gstd_log_init (gstdlogfile, gstlogfile)) { | |||
| if (!gstd_log_init (gstdlogfile, gstlogfile, !nolog && !kill)) { | |||
There was a problem hiding this comment.
This seems hard to read to me without comment. Should we separate the logic and create a boolean with the name enabled for readability and add that the logging is only enabled under certain conditions as a small comment?
michaelgruner
force-pushed
the
feature/allow-disabling-daemon-logs
branch
from
3252b9e to
f232198
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #274