add event type & source to "multiple listeners" warning #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelgruner
requested changes
Mar 15, 2021
| @@ -889,8 +889,11 @@ gst_inter_pipe_sink_receive_event (GstInterPipeINode * iface, GstEvent * event) | |||
|
|
|||
| multiple_listeners: | |||
| { | |||
| GST_WARNING_OBJECT (self, "Could not send event upstream, " | |||
| "more than one listener is connected"); | |||
| gchar* evtype = g_ascii_strup(GST_EVENT_TYPE_NAME(event), -1); | |||
There was a problem hiding this comment.
I suggest just using GST_EVENT_TYPE_NAME(event) directly instead of dropping the case and needing to free later.
| @@ -870,7 +870,7 @@ gst_inter_pipe_sink_remove_listener (GstInterPipeINode * iface, | |||
| } | |||
|
|
|||
| static gboolean | |||
| gst_inter_pipe_sink_receive_event (GstInterPipeINode * iface, GstEvent * event) | |||
| gst_inter_pipe_sink_receive_event (GstInterPipeINode * iface, GstInterPipeIListener * listener, GstEvent * event) | |||
There was a problem hiding this comment.
We need a pointer guard for listener. And, incidentally, could you add one for event as well?
|
@mildsunrise thanks for your contribution, I agree with your suggestion. I've added a couple of my own on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Could not send event upstream, more than one listener is connected" warnings are common, spammy and often don't represent a problem... IMO it would be handy to at least log the event type, and the listener it came from.