Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove py 3.7 and add apptainer 1.1.5 #490

Merged
merged 6 commits into from
Jan 14, 2023
Merged

fix: remove py 3.7 and add apptainer 1.1.5 #490

merged 6 commits into from
Jan 14, 2023

Conversation

satra
Copy link
Contributor

@satra satra commented Jan 14, 2023

No description provided.

@kaczmarj
Copy link
Collaborator

looks great. to speed up the ci, we can install the prebuilt deb files for apptainer. apptainer github releases have these debs. we would have to install the "regular" deb as well as the deb that adds suid capabilities.

wget https://github.com/apptainer/apptainer/releases/download/v1.1.5/apptainer_1.1.5_amd64.deb
wget https://github.com/apptainer/apptainer/releases/download/v1.1.5/apptainer-suid_1.1.5_amd64.deb
sudo apt-get install --yes ./apptainer*

and then we would not have to wait for apptainer to compile.

@satra
Copy link
Contributor Author

satra commented Jan 14, 2023

thanks @kaczmarj - i'll add that. currently fixing tests on master.

satra added 5 commits January 14, 2023 13:40
* origin/master:
  fix flake
  remove minify option and tests
  fix: adjust optionEatAll for click >= 8
* fix/tests:
  CFG: restrict workflows to PRs only
@codecov
Copy link

codecov bot commented Jan 14, 2023

Codecov Report

Base: 83.74% // Head: 83.72% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (218697a) compared to base (7ae8b29).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #490      +/-   ##
==========================================
- Coverage   83.74%   83.72%   -0.02%     
==========================================
  Files          11       11              
  Lines        1015     1014       -1     
==========================================
- Hits          850      849       -1     
  Misses        165      165              
Impacted Files Coverage Δ
neurodocker/cli/generate.py 90.95% <0.00%> (-0.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satra satra merged commit 0d4b4c0 into master Jan 14, 2023
@Remi-Gau Remi-Gau deleted the fix/test-state branch August 21, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants