Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] auto doc main CLI #463

Merged
merged 8 commits into from
Sep 3, 2023
Merged

[DOC] auto doc main CLI #463

merged 8 commits into from
Sep 3, 2023

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Aug 4, 2022

in case someone feels like working on this. I am opening a draft here.

from my quick look it seems that all the many options are not automatically capture, so documentation automation may require refactoring some of the cli code. Or there is a way to make auto click figure this out but I am not sure.

@kaczmarj
Copy link
Collaborator

kaczmarj commented Aug 4, 2022 via email

@stebo85
Copy link
Collaborator

stebo85 commented Aug 22, 2023

@Remi-Gau - what is the status of this?

@Remi-Gau
Copy link
Collaborator Author

@Remi-Gau - what is the status of this?

From. Memory there was some issue with click I think. Need to double check.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@Remi-Gau
Copy link
Collaborator Author

retried... it works... meaning it does not crash... but the generated doc is underwhelming...

image

Apparently this sphinx-click extension cannot capture all the options... At least in the way this is set up.

@Remi-Gau Remi-Gau marked this pull request as draft August 22, 2023 09:15
@Remi-Gau Remi-Gau marked this pull request as ready for review September 3, 2023 15:19
@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Sep 3, 2023

Tried a different strategy: simply generate the help section with a bash script, dump it into a text file and include it in the rst.

It looks more "packed" than the previous version but at least it will always be up to date.

image

Comment on lines +63 to +86
html_theme_options = {
"use_edit_page_button": True,
"icon_links": [
{
"name": "GitHub",
"url": "https://github.com/ReproNim/neurodocker",
"icon": "fa-brands fa-github",
},
{
"name": "Docker Hub",
"url": "https://hub.docker.com/r/repronim/neurodocker",
"icon": "fa-brands fa-docker",
},
],
}


html_context = {
"github_user": "ReproNim",
"github_repo": "neurodocker",
"github_version": "master",
"doc_path": "docs",
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are just to add links to the repos on github or docker hub in the navbar and to add an "edit source" link when browsing the doc.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this. i always appreciate when i'm able to easily browse the source from the documentation.

@Remi-Gau Remi-Gau requested a review from kaczmarj September 3, 2023 15:27
Copy link
Collaborator

@kaczmarj kaczmarj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great @Remi-Gau thanks very much! i only see one change that needs to be made. can you remove the docker badge that pointed to the kaczmarj dockerhub namespace? let's only have one docker badge, that points to repronim's account.

README.md Outdated Show resolved Hide resolved
Comment on lines +63 to +86
html_theme_options = {
"use_edit_page_button": True,
"icon_links": [
{
"name": "GitHub",
"url": "https://github.com/ReproNim/neurodocker",
"icon": "fa-brands fa-github",
},
{
"name": "Docker Hub",
"url": "https://hub.docker.com/r/repronim/neurodocker",
"icon": "fa-brands fa-docker",
},
],
}


html_context = {
"github_user": "ReproNim",
"github_repo": "neurodocker",
"github_version": "master",
"doc_path": "docs",
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this. i always appreciate when i'm able to easily browse the source from the documentation.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Jakub Kaczmarzyk <[email protected]>
@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Sep 3, 2023

will wait for CI to finish and merge

@Remi-Gau Remi-Gau merged commit f1ee11f into ReproNim:master Sep 3, 2023
12 checks passed
@Remi-Gau Remi-Gau deleted the autodoc branch September 3, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] missing commands in the online doc
3 participants