Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add freesurfer 7.3.0 and 7.3.1 #459

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Conversation

jennydaman
Copy link
Contributor

No description provided.

@yarikoptic
Copy link
Member

just to make sure -- @jennydaman did you try building with both of those versions and had some basic testing of containers done? (since AFAIK there is no CI for such things here)

@jennydaman
Copy link
Contributor Author

Ehe, perhaps the branch name patch-1 revealed that I've been a little lazy here...

It's building on my local machine rn and I'll follow up this afternoon.

@jennydaman
Copy link
Contributor Author

Here's what I did to try the build:

git clone --branch patch-1 localhost/jennydaman/neurodocker:latest
cd neurodocker
docker build -t localhost/jennydaman/neurodocker .
mkdir freesurfer_example
cd freesurfer_example
docker run --rm -it localhost/jennydaman/neurodocker:latest \
	generate docker \
	    --pkg-manager apt \
	    --base-image debian:buster-slim \
	    --freesurfer version=7.3.1 \
	> Dockerfile
docker build -t localhost/jennydaman/neurodocker-freesurfer:7.3.1 .

I confirmed basic working state:

$ docker run --rm localhost/jennydaman/neurodocker-freesurfer:7.3.1 which recon-all
/opt/freesurfer-7.3.1/bin/recon-all
$ docker run --rm localhost/jennydaman/neurodocker-freesurfer:7.3.1 recon-all -version
freesurfer-linux-centos7_x86_64-7.3.1-20220723-115e466

@jennydaman
Copy link
Contributor Author

@yarikoptic this is unexpected.

On my fork I enabled Actions and created a dummy PR, the same unit test fails on master. jennydaman#1

@yarikoptic yarikoptic mentioned this pull request Jul 29, 2022
@yarikoptic
Copy link
Member

"cool", filed dedicated #460

Let's proceed! Thank you!

@yarikoptic yarikoptic merged commit ce1c0cb into ReproNim:master Jul 29, 2022
@kaczmarj
Copy link
Collaborator

thanks @yarikoptic and @jennydaman

we will look into the bug causing tests to fail. thanks for identifying this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants