Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPX support #473

Open
wants to merge 157 commits into
base: master
Choose a base branch
from
Open

HPX support #473

wants to merge 157 commits into from

Conversation

ct-clmsn
Copy link

@ct-clmsn ct-clmsn commented Jan 23, 2024

This PR finalizes work started last year that adds HPX runtime system support to Embree. HPX is an asynchronous many task runtime system implementing ISO C++ STL's data parallelism and concurrency API. HPX is implemented over a user-land thread implementation and tends to yield good strong and weak scaling performance.

ctaylor and others added 30 commits April 7, 2023 08:58
- Increase test timeout of bvh_builder test
- always disable SSE2 for imgui
* removed 'perf' tag from A770

* more precise wildcards
- separate cpack test component
 - new ADD_EMBREE_TEST cmake macro
 - moved reference image directly beside test definition files
 - updated package scripts
This follows the same method that Cycles uses to ignore backfacing
sphere intersections.
* Moved sphere backface culling documentation to the right place
svenwoop and others added 21 commits January 22, 2024 22:19
* coverity test
* fixing coverity issues
* disable klockwork
The decision is not finalized yet, which folder layout the new ICX
release will have. We now add both versions and hope for the best.
* use syclos 20230922 for release
* use proper public driver on Windows
* update ispc to 1.21.0
* update TBB to 2021.10.0
* update ICX RK to 20230926
@ct-clmsn ct-clmsn changed the title HPX support for embree HPX support Jan 23, 2024
@ct-clmsn
Copy link
Author

ct-clmsn commented Jan 24, 2024

Updated readme and licenses where appropriate; the support was developed on a Mac M2 environment and an x86 environment.

@jenetscaria-mcw
Copy link

@ct-clmsn , we tried to run embree pathtracer example with hpx in an x64 system. We have installed hpx from the source and tried configuring HPX with -DHPX_WITH_MALLOC option with tcmalloc, jemalloc and system but we are facing errors as:

hpx::init: std::exception caught: Requested more than 64 --hpx:threads to use for this application, use the option -DHPX_WITH_MAX_COUNT_CPU_COUNT=<N> when configuring HPX.
Error: std::bad_alloc

We have tried modifying DHPX_WITH_MAX_COUNT_CPU_COUNT option and always ending up at the same error. Have you faced this issue before?

@ct-clmsn
Copy link
Author

ct-clmsn commented Jun 1, 2024

@jenetscaria-mcw my apologies for the late response. I'll verify this on an x86 system. The development work was done on a Mac Arm gen2 machine. I hadn't seen this particular issue before on that system but the x86 system should be a good test environment for this problem. Thank you for your time and patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants