Fix CMake compile flags definition. #398
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building embree as a subproject (via
add_subdirectory()
) and as a static library on Windows, I do get a bunch of errors of the sort:This is because the compile flag
EMBREE_STATIC_LIB
is only defined for embree files (such asrtcore.cpp
), but is NOT propagated transitively to downstream targets. The reason is that Embree's CMake uses the deprecated constructadd_definitions()
, which adds flags to a folder property. The modern CMake way to do this is to work with target properties instead, attaching compile flags to targets and properly express which ones should be transitively propagated (PUBLIC
orINTERFACE
properties).This PR remedies this shortcoming by attaching all compilation flags to a new
INTERFACE
targetembree_config
, which will properly propagate the information to downstream targets.