RHIROS-987 - upgrade flask,werkzeug to newer versions

[upadhyeammit]

Why do we need this change? 💭

• This updates the flask*, werkzeug and rest of the packages to latest version.
• This removes the pinning of the markupsafe = "==2.0.1" as I don't see any of the latest dependencies using soft_unicode from markupsafe. More about issue at ImportError: cannot import name 'soft_unicode' from 'markupsafe' in Release 1.38.0 aws/aws-sam-cli#3661

Documentation update? 📝

• Yes
• No

Security Checklist 🔒

Upon raising this PR please go through RedHatInsights/secure-coding-checklist

💂‍♂️ Checklist 🎯

• Bugfix
• New Feature
• Refactor
• Unittests Added
• DRY code
• Dependency Updated
• DB Migration Added

[upadhyeammit]

This updates flask to 2.2.3, I am yet to go through change matrix of 2.2.1, 2.2.2 and 2.2.3 https://github.com/pallets/flask/releases

[kgaikwad]

@upadhyeammit, PR jobs are not happy. There is failure related to pytest.

[upadhyeammit]

The sqlalchemy query api has been deprecated and we will need to migrate the queries as per new 2.0 specification : https://docs.sqlalchemy.org/en/20/changelog/migration_20.html#migration-20-query-usage . I will checking this further.

[upadhyeammit]

We are using flask-script for the cmds, this is not compatible with latest flask version, instead we will need to go with flask-cli way,

https://github.com/smurfix/flask-script
https://flask.palletsprojects.com/en/2.2.x/cli/

[kgaikwad]

/retest

[upadhyeammit]

After rebase I can see test failures :\ I am still working on to get all queries based on 2.0 spec

[codecov-commenter]

Codecov Report

Patch coverage: 89.33% and project coverage change: +0.38 🎉

Comparison is base (c9f219b) 72.52% compared to head (bcba3ab) 72.91%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
+ Coverage   72.52%   72.91%   +0.38%     
==========================================
  Files          28       29       +1     
  Lines        1354     1377      +23     
==========================================
+ Hits          982     1004      +22     
- Misses        372      373       +1     

Flag	Coverage Δ
unittests	72.91% <89.33%> (+0.38%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
ros/api/v1/recommendations.py	86.48% <66.66%> (-1.40%)	⬇️
ros/processor/insights_engine_consumer.py	69.72% <75.00%> (-1.03%)	⬇️
ros/lib/utils.py	84.97% <77.77%> (+0.97%)	⬆️
ros/processor/inventory_events_consumer.py	46.00% <80.00%> (+0.54%)	⬆️
ros/api/common/utils.py	93.22% <100.00%> (+0.62%)	⬆️
ros/api/main.py	93.75% <100.00%> (+0.89%)	⬆️
ros/api/v1/call_to_action.py	29.16% <100.00%> (ø)
ros/api/v1/hosts.py	86.52% <100.00%> (ø)
ros/api/v1/status.py	100.00% <100.00%> (ø)
ros/extensions.py	100.00% <100.00%> (ø)
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[upadhyeammit]

/retest

[ShivamPandya]

/retest

[upadhyeammit]

/retest

[upadhyeammit]

As per the discussion with @yash2189 the EE failures should not be related to this change. He is checking further on this.

[upadhyeammit]

/retest

[yash2189]

/retest

[upadhyeammit]

/retest

[saltgen]

@upadhyeammit Could you add some unittests for the code changes for example, the subquery change?
IMO it would be better to assert behavior consistency this way.

[saltgen]

@upadhyeammit Shall we add the Poetry changes here, after #331 is approved? Or vice versa?

[r14chandra]

Looks good to me now 👍🏻.
Thanks @upadhyeammit for resolving the comments!

[kgaikwad]

Few suggestions added. Please feel free to address those in same or separate pull-request.

[kgaikwad]

@upadhyeammit - jobs are not happy :)

[upadhyeammit]

@upadhyeammit - jobs are not happy :)

I rebased, squashed and looks like we are green!

[upadhyeammit]

Thank you @kgaikwad @r14chandra and @saltgen for reviews! I am merging this one now!