Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silent 400 error when headers exceed 8KiB #38

Open
1 of 3 tasks
cben opened this issue May 9, 2021 · 1 comment · May be fixed by #39
Open
1 of 3 tasks

Silent 400 error when headers exceed 8KiB #38

cben opened this issue May 9, 2021 · 1 comment · May be fixed by #39

Comments

@cben
Copy link
Contributor

cben commented May 9, 2021

Several people on our team have been plagued by a heisenbug — some requests sometimes start failing with status 400, no explanation and nothing logged 😕

Turns out we're hitting NodeJS limit of 8KiB headers (nodejs/node@1860352), when you accumulate too many cookies. 💡 A different tab / incognito might help because different cookies. Only some requests fail because they're longer...
@cben
Copy link
Contributor Author

cben commented May 18, 2021

  • Workaround specific to OCM (cloud.redhat.com/openshift): append ?env=staging to browser URL to make OCM UI talk directly to stage API, bypassing insights-proxy.

cben added a commit to cben/insights-proxy that referenced this issue May 18, 2021
@cben
Use fedora 33 with new NodeJS 14.16
c7f31b3 
Fedora 29 has nodejs 10.16.3 which is EOL.
Fedora 33 (and 34) currently has 14.16.1.

The newer NodeJS improves RedHatInsights#38
by returning 431 Request Header Fields Too Large
instead of 400 Bad Request that NodeJS 10 returned.
@cben cben linked a pull request May 18, 2021 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use fedora 33, set large --max-http-header-size cben/insights-proxy
1 participant
@cben