feat(shareReplay): added 'disconnect' feature #4411
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updated shareReplay to support 'disconnect'. That is, when the refCount drops to 0, the buffer can (optionally) be dropped, and then, upon the next subscription, re-subscribes to the source.
Rather than adding another parameter, a config-object interface has been added. For compatibility, the old parameters still work, but the disconnect option can only be reached with the config option, so
shareReplay(3)
is equivalent toshareReplay({ bufferSize: 3})
, but you might instead wantshareReplay({ bufferSize: 3, disconnect: true})
.Related issue (if exists):
This is in response to issue 3722.