treewide: Apply changes for new svd2rust API #545
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As avr-device is upgrading to use svd2rust version 0.33.1, there are
some significant changes in the generated API. We have to adapt the HAL
code to use the new API whereever relevant.
This commit was mostly generated using the following command, which adds
the parentheses behind each register access to change it from
struct-field access to method call.
cargo build --message-format json 2>/dev/null \
| jq '.message.children[].spans[] | {file: .file_name, line: .line_start, col: (.text[0].highlight_start - 1), insert: .suggested_replacement}' 2>/dev/null \
| jq -r '"sed -ri '"'"'" + (.line | tostring) + "s/^(.{" + (.col | tostring) + "})/\\1" + .insert + "/'"'"' $(cd ../..; realpath " + .file + ")"' \
| sort | uniq | bash
Shell magic for the win :)
Beyond this, .bits() had to be converted to .set() where safe accesses
are performed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As avr-device is upgrading to use svd2rust version 0.33.1 (see Rahix/avr-device#155), there are some significant changes in the generated API. We have to adapt the HAL code to use the new API whereever relevant. This PR is a preview of what will change.
The following major changes are necessary:
.set()method instead of.bits().Fortunately, these changes can be trivially automated from rustc error messages using the following script: