Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-11-29, Version 23.3.1 (Current), @RafaelGSS #8

Closed
wants to merge 62 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
1f2fcf1
doc: add history entries for JSON modules stabilization
aduh95 Nov 16, 2024
00e092b
util: fix util.getCallSites plurality
legendecas Nov 2, 2024
d4e7926
util: add sourcemap support to getCallSites
marco-ippolito Nov 4, 2024
7814669
tools: fix c-ares updater script for Node.js 18
richardlau Nov 6, 2024
bbb8f59
lib: use `Promise.withResolvers()` in timers
anonrig Nov 6, 2024
e147935
deps: update icu to 76.1
nodejs-github-bot Nov 7, 2024
cfe28b1
lib: remove unnecessary optional chaining
gurgunday Nov 7, 2024
d1ad43e
test: improve test coverage for `ServerResponse`
juanarbol Nov 7, 2024
5767b76
doc: enforce strict policy to semver-major releases
RafaelGSS Nov 7, 2024
e1b42e7
test: add buffer to fs_permission tests
RafaelGSS Nov 7, 2024
1568733
lib: prefer symbol to number in webidl `type` function
aduh95 Nov 7, 2024
9862912
assert: differentiate cases where `cause` is `undefined` or missing
aduh95 Nov 8, 2024
e1f54e2
test: ensure that test priority is not higher than current priority
LiviaMedeiros Nov 8, 2024
8576ca9
doc: clarify removal of experimental API does not require a deprecation
aduh95 Nov 8, 2024
db0d648
fs: fix bufferSize option for opendir recursive
Ethan-Arrowood Nov 8, 2024
3a9733c
util: do not mark experimental feature as deprecated
aduh95 Nov 8, 2024
84c4747
test: improve test coverage for child process message sending
juanarbol Nov 8, 2024
ccb69bb
src: add cli option to preserve env vars on dr
RafaelGSS Nov 8, 2024
16786a6
src: improve `node:os` userInfo performance
anonrig Nov 8, 2024
aa12de0
doc: sort --report-exclude alphabetically
RafaelGSS Nov 9, 2024
419ea06
tools: remove non-existent file from eslint config
RedYetiDev Nov 10, 2024
8111a76
tools: make commit-queue check blocked label
marco-ippolito Nov 10, 2024
3cfacd3
tools: fix exclude labels for commit-queue
richardlau Nov 10, 2024
bba7323
build: apply cpp linting and formatting to ncrypto
RedYetiDev Nov 10, 2024
7773567
build: use glob for dependencies of out/Makefile
richardlau Nov 10, 2024
df5ea1a
doc: clarify triager role
gireeshpunathil Nov 10, 2024
472d55e
build: implement node_use_amaro flag in GN build
zcbenz Nov 11, 2024
9aeb671
doc: run license-builder
github-actions[bot] Nov 11, 2024
83ba688
esm: fix import.meta.resolve crash
marco-ippolito Nov 11, 2024
9c99255
permission: ignore internalModuleStat on module loading
RafaelGSS Nov 11, 2024
c210335
benchmark: add `test_runner/mock-fn`
RedYetiDev Nov 11, 2024
e0db9ed
deps: update c-ares to v1.34.3
nodejs-github-bot Nov 12, 2024
5a437c4
report: fix network queries in getReport libuv with exclude-network
Tofandel Nov 12, 2024
770670c
test: fix permission fixtures lint
RafaelGSS Nov 12, 2024
65ffb2c
doc: update unflag info of `import.meta.resolve`
skyclouds2001 Nov 12, 2024
c5afdaf
doc: correct max-semi-space-size statement
joebowbeer Nov 12, 2024
11e1bdd
module: tidy code string concat → string templates
JakobJingleheimer Nov 13, 2024
e56265c
doc: fix history info for `URL.prototype.toJSON`
aduh95 Nov 13, 2024
787e51e
doc: add notable-change mention to sec release
RafaelGSS Nov 14, 2024
bdb6d12
events: add hasEventListener util for validate
sungpaks Nov 14, 2024
a831184
doc: clarify UV_THREADPOOL_SIZE env var usage
preveen-stack Nov 15, 2024
1b863b9
doc: add `-S` flag release preparation example
aduh95 Nov 15, 2024
32e5bbc
benchmark: add `test-reporters`
RedYetiDev Nov 16, 2024
ec953bc
doc: add `node:sqlite` to mandatory `node:` prefix list
sapphi-red Nov 16, 2024
e0ef65b
doc: remove non-working example
aduh95 Nov 16, 2024
dc8aca3
deps: update undici to 6.21.0
nodejs-github-bot Nov 16, 2024
cad557e
deps: update simdutf to 5.6.1
nodejs-github-bot Nov 16, 2024
58d7a6e
Revert "src: migrate `String::Value` to `String::ValueView`"
targos Nov 16, 2024
49d5522
src: use env strings to create sqlite results
targos Nov 17, 2024
034505e
test_runner: error on mocking an already mocked date
RedYetiDev Nov 17, 2024
d41cb49
fs: prevent unwanted `dependencyOwners` removal
Ceres6 Nov 17, 2024
e0c2225
crypto: allow length=0 for HKDF and PBKDF2 in SubtleCrypto.deriveBits
panva Nov 17, 2024
44324aa
tools: bump @eslint/plugin-kit from 0.2.0 to 0.2.3 in /tools/eslint
dependabot[bot] Nov 17, 2024
bcbba72
sqlite: add support for SQLite Session Extension
louwers Nov 18, 2024
693fda0
lib: remove unused file `fetch_module`
targos Nov 18, 2024
72f82ad
2024-11-20, Version 23.3.0 (Current)
RafaelGSS Nov 19, 2024
176b16a
Working on v23.3.1
RafaelGSS Nov 20, 2024
65b95fe
build: add create release proposal action
RafaelGSS Nov 1, 2024
77e1843
fixup! build: add create release proposal action
RafaelGSS Nov 22, 2024
4af58d8
fixup! fixup! build: add create release proposal action
RafaelGSS Nov 22, 2024
009a5fd
fixup! fixup! fixup! build: add create release proposal action
RafaelGSS Nov 22, 2024
e625651
2024-11-29, Version 23.3.1 (Current)
nodejs-github-bot Nov 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: use env strings to create sqlite results
PR-URL: nodejs#55785
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos authored and RafaelGSS committed Nov 18, 2024

Verified

This commit was signed with the committer’s verified signature.
RafaelGSS Rafael Gonzaga
commit 49d55228de8d5752212e977e79d6caf7b8aa6892
2 changes: 2 additions & 0 deletions src/env_properties.h
Original file line number Diff line number Diff line change
@@ -90,6 +90,7 @@
V(cached_data_string, "cachedData") \
V(cache_key_string, "cacheKey") \
V(change_string, "change") \
V(changes_string, "changes") \
V(channel_string, "channel") \
V(chunks_sent_since_last_write_string, "chunksSentSinceLastWrite") \
V(clone_unsupported_type_str, "Cannot clone object of unsupported type.") \
@@ -215,6 +216,7 @@
V(jwk_y_string, "y") \
V(kill_signal_string, "killSignal") \
V(kind_string, "kind") \
V(last_insert_rowid_string, "lastInsertRowid") \
V(length_string, "length") \
V(library_string, "library") \
V(line_number_string, "lineNumber") \
11 changes: 5 additions & 6 deletions src/node_sqlite.cc
Original file line number Diff line number Diff line change
@@ -694,10 +694,6 @@ void StatementSync::Run(const FunctionCallbackInfo<Value>& args) {
}

Local<Object> result = Object::New(env->isolate());
Local<String> last_insert_rowid_string =
FIXED_ONE_BYTE_STRING(env->isolate(), "lastInsertRowid");
Local<String> changes_string =
FIXED_ONE_BYTE_STRING(env->isolate(), "changes");
sqlite3_int64 last_insert_rowid =
sqlite3_last_insert_rowid(stmt->db_->Connection());
sqlite3_int64 changes = sqlite3_changes64(stmt->db_->Connection());
@@ -713,9 +709,12 @@ void StatementSync::Run(const FunctionCallbackInfo<Value>& args) {
}

if (result
->Set(env->context(), last_insert_rowid_string, last_insert_rowid_val)
->Set(env->context(),
env->last_insert_rowid_string(),
last_insert_rowid_val)
.IsNothing() ||
result->Set(env->context(), changes_string, changes_val).IsNothing()) {
result->Set(env->context(), env->changes_string(), changes_val)
.IsNothing()) {
return;
}