Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove elementwise kernel before each fp8 gemm #81

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

charlifu
Copy link

@charlifu charlifu commented Jul 9, 2024

Currently, our fp8 linear layer runs the linear adjustment before every gemm operation. This PR changes it to do it once after weight loading.

Both fp8 and fp16 models were tested.

@charlifu charlifu merged commit c3e8349 into main Jul 9, 2024
13 checks passed
Copy link

@HaiShaw HaiShaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants