Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradlib fp8 output #76

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Fix gradlib fp8 output #76

merged 5 commits into from
Jul 1, 2024

Conversation

charlifu
Copy link

@charlifu charlifu commented Jun 28, 2024

Current gradlib crashes on fp8 output, since pytorch allclose does not support float8_e4m3fnuz type.

This PR changes the way of gradlib to do the gemm result accuracy check by converting all gemm result to float32.

Beside, this PR also adds a condition check for concatenation with existing tuned result.

@charlifu charlifu requested a review from gshtras June 28, 2024 19:41
@charlifu charlifu merged commit 52df169 into main Jul 1, 2024
13 checks passed
@charlifu charlifu deleted the charlifu/fix_gradlib_fp8_output branch August 5, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant