Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging fp8_gemm_tuner.py to gemm_tuner.py #66

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Merging fp8_gemm_tuner.py to gemm_tuner.py #66

merged 5 commits into from
Jun 25, 2024

Conversation

charlifu
Copy link

@charlifu charlifu commented Jun 25, 2024 •
edited
Loading

Currently, we are using a separate fp8_gemm_tuner.py to tune the fp8 gemm, since fp8 gemm only needs hipblaslt, and it can have different output dtypes.

This PR removes fp8_gemm_tuner.py and add fp8 gemm tuning functionality to gemm_tuner.py, by:

  • change --dtype to --indtpye.
  • add --outdtype
  • use rocblas when input dtype equals to output dtype and is not fp8.

@charlifu charlifu requested a review from shajrawi June 25, 2024 15:52
shajrawi
shajrawi approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@shajrawi shajrawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@charlifu charlifu merged commit 367aa5a into main Jun 25, 2024
13 checks passed
@charlifu charlifu deleted the charlifu/merge_gradlib branch June 28, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shajrawi shajrawi shajrawi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlifu @shajrawi