Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Runtime Error When Loading kv cache scales #65

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Fix the Runtime Error When Loading kv cache scales #65

merged 1 commit into from
Jun 24, 2024

Conversation

charlifu
Copy link

@charlifu charlifu commented Jun 24, 2024 •
edited
Loading

The kv_scale attribute has been moved to layer_self_attn.attn in the newer upstream, but we are still checking the layer_self_attn. And there is no kv_scale attribute in layer_self_attn.

This PR fixes this issue by checking the _kv_scale attribute of layer_self_attn.attn.

@charlifu charlifu requested review from mawong-amd and shajrawi June 24, 2024 15:39
shajrawi
shajrawi approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@shajrawi shajrawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

@charlifu charlifu merged commit 17e6307 into main Jun 24, 2024
13 checks passed
@mawong-amd mawong-amd deleted the charlifu/fix_error_kv_cache_scales_loading branch June 25, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shajrawi shajrawi shajrawi approved these changes

@mawong-amd mawong-amd Awaiting requested review from mawong-amd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlifu @shajrawi