Custom PA Partition size 256 to improve performance #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshtras
reviewed
Oct 22, 2024
| @@ -316,12 +316,14 @@ __global__ __launch_bounds__(NUM_THREADS) void paged_attention_ll4mi_QKV_kernel( | |||
| int vphysical_blocks[VBLOCKS]; | |||
|
|
|||
| const int warp_start_block_idx = warp_start_token_idx / BLOCK_SIZE; | |||
| if constexpr (GQA_RATIO < 12) { | |||
There was a problem hiding this comment.
Will not block this merge because of this, but please consider turning this magic 12 into a named constant in a subsequent
gshtras
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to control partition size in Custom PA launcher.
Change default Partition Size to 256 to improve performance across products/ cases.
Change CPA reduction kernel template switch case to support 128K context length with Partition Size 256.