Test fixes for Python 3.9 #544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot. This saves me from figuring out how to fix them for Gentoo ;-). |
|
Please rewrite this change so that pre-3.9 functionality tests are not lost. |
|
I am not available to do that now, sorry. Feel free to build on top of this or rework it entirely. I am not familiar with future code base and everything I knew about it in February is unfortunately long gone from my head. I've opened this PR to fix a problem we had in Fedora - I don't like downstream only patches - at that time, I was able to dive in. |
Merged
|
It would be good to merge this and make ne release. |
|
Merged #578, which supersedes this PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #540
Fixes #541