Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: ♻️ Use typing_extensions instead of _typed_dict #2621

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

refactor: ♻️ Use typing_extensions instead of _typed_dict #2621

wants to merge 5 commits into from

Conversation

Paillat-dev
Copy link
Contributor

@Paillat-dev Paillat-dev commented Oct 24, 2024 •
edited
Loading

Summary

Information

  • This PR fixes an issue.
    fixes: Remove _typed_dict.py #2166
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Paillat-dev Paillat-dev requested a review from a team as a code owner October 24, 2024 12:44
@pullapprove4 pullapprove4 bot requested a review from VincentRPS October 24, 2024 12:44
@Paillat-dev Paillat-dev changed the title core: ♻️ Use typing_extensions instead of _typed_dict chore: ♻️ Use typing_extensions instead of _typed_dict Oct 24, 2024
@Paillat-dev Paillat-dev changed the title chore: ♻️ Use typing_extensions instead of _typed_dict refactor: ♻️ Use typing_extensions instead of _typed_dict Oct 24, 2024
@Paillat-dev
Copy link
Contributor Author

Does this need changelog ?

@Paillat-dev Paillat-dev mentioned this pull request Oct 28, 2024
Open
9 tasks
@plun1331 plun1331 added priority: low Low Priority status: awaiting review Awaiting review from a maintainer dependencies Pull requests that update a dependency file labels Oct 29, 2024
@Dorukyum
Copy link
Member

Does this need changelog ?

Nope, just need to test if this works for typing_extensions 4.0.0 since that's the lowest allowed version in the requirements.

@Paillat-dev
Copy link
Contributor Author

Paillat-dev commented Nov 11, 2024 •
edited
Loading

image
image
It does work, I will test again and merge master in here

@Dorukyum
Copy link
Member

TypedDict has had changes after 4.0.0 (ref), we'd better test both older and newer versions.

@Paillat-dev
Copy link
Contributor Author

will do

@Paillat-dev
Copy link
Contributor Author

Paillat-dev commented Dec 2, 2024 •
edited
Loading

#2655 requires 4.5.0 at least. Do I test from that up ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentRPS VincentRPS Awaiting requested review from VincentRPS

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file PA: All Contributors pending PA: Maintainers pending priority: low Low Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove _typed_dict.py
3 participants
@Paillat-dev @Dorukyum @plun1331