-
-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement positional flags #2443
Open
Vioshim
wants to merge
10
commits into
Pycord-Development:master
Choose a base branch
from
Vioshim:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dorukyum
reviewed
May 20, 2024
JustaSqu1d
suggested changes
May 20, 2024
Dorukyum
changed the title
feat: Implements positional flags
feat: implement positional flags
Jun 28, 2024
Dorukyum
requested changes
Jun 28, 2024
Co-authored-by: Dorukyum <[email protected]> Co-authored-by: JustaSqu1d <[email protected]> Signed-off-by: Lala Sabathil <[email protected]>
@Vioshim please work on dorus comment and resolve conflcts |
JustaSqu1d
added
priority: medium
Medium Priority
feature
Implements a feature
python
Pull requests that update Python code
and removed
documentation needed
labels
Aug 7, 2024
Signed-off-by: Lala Sabathil <[email protected]>
The typing import in flags.py has been updated to include the Optional module. This change ensures that the __commands_flag_positional__ attribute can accept a value of None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
Implements a feature
priority: medium
Medium Priority
python
Pull requests that update Python code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows FlagConverters to be used after the first text expression, for example
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.