Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Duplication in bridge command help #2415

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

Blue-Robin-Taken
Copy link
Contributor

Summary

This pull request is for the issue #2306

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Signed-off-by: BlueRobin <[email protected]>
Lulalaby
Lulalaby previously approved these changes Apr 6, 2024
@Lulalaby Lulalaby enabled auto-merge (squash) April 6, 2024 17:22
@Lulalaby Lulalaby requested review from Dorukyum and JustaSqu1d and removed request for BobDotCom April 6, 2024 17:23
CHANGELOG.md Outdated Show resolved Hide resolved
discord/ext/commands/help.py Outdated Show resolved Hide resolved
Signed-off-by: BlueRobin <[email protected]>
auto-merge was automatically disabled April 9, 2024 20:22

Head branch was pushed to by a user without write access

@Blue-Robin-Taken
Copy link
Contributor Author

I haven't checked if the code works yet but I will when I get home

@plun1331 plun1331 linked an issue Apr 12, 2024 that may be closed by this pull request
3 tasks
@plun1331 plun1331 added the bug Something isn't working label Apr 12, 2024
@plun1331
Copy link
Member

plun1331 commented May 6, 2024

I haven't checked if the code works yet but I will when I get home

Any updates?

@Blue-Robin-Taken
Copy link
Contributor Author

Blue-Robin-Taken commented May 6, 2024

Thanks for the reminder, I currently do not have time atm to check it still 💀
finals are coming up and I might be able to check tomorrow

sorry

@Blue-Robin-Taken
Copy link
Contributor Author

I'm definitely going to wait to do this after final exams or maybe if I have time this weekend

@@ -44,6 +44,8 @@ These changes are available on the `master` branch, but have not yet been releas
([#2407](https://github.com/Pycord-Development/pycord/pull/2407))
- Fixed invalid data being passed to `Interaction._guild` in certain cases.
([#2411](https://github.com/Pycord-Development/pycord/pull/2411))
- Fixed `BridgeCommand` duplication in default help commands.
([#2415](https://github.com/Pycord-Development/pycord/pull/2415))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move changelog to new section

@Lulalaby
Copy link
Member

@Blue-Robin-Taken

@Lulalaby Lulalaby added this to the v2.7 milestone Aug 10, 2024
@Blue-Robin-Taken
Copy link
Contributor Author

Blue-Robin-Taken commented Aug 10, 2024

I just started junior year of HS and if I have time today (cause it's the weekend) I'll get on it
Thanks for the notifs @Lulalaby !

@Lulalaby
Copy link
Member

Thanks, ping me when ready to review

@ChickenDevs
Copy link
Member

@Blue-Robin-Taken Just wanted to follow up on this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PA: Maintainers pending
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command duplication in cog help
5 participants