Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add supported CPython/PyPy versions to cargo package metadata #4756

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add supported CPython/PyPy versions to cargo package metadata #4756

wants to merge 1 commit into from

Conversation

messense
Copy link
Member

@messense messense commented Dec 3, 2024 •
edited
Loading

I tried to use workspace inheritance to reduce duplication, but when inspecting the cargo package artifact It does not seem to work.

Closes #4751

@messense messense force-pushed the cpython-pypy-version-support-metadata branch from 7a38b06 to 1aaca98 Compare December 3, 2024 12:19
@messense messense requested a review from davidhewitt December 3, 2024 14:40
davidhewitt
davidhewitt reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, do you think there's a way that we can test this? Maybe a small nox job which inspects the output of cargo metadata?

pyo3-ffi/Cargo.toml Outdated Show resolved Hide resolved
@messense messense force-pushed the cpython-pypy-version-support-metadata branch from 1aaca98 to a2d6030 Compare December 5, 2024 10:58
@messense
Copy link
Member Author

messense commented Dec 5, 2024

Test added.

@messense messense force-pushed the cpython-pypy-version-support-metadata branch from a2d6030 to 0bc5125 Compare December 5, 2024 10:59
@messense messense requested a review from davidhewitt December 5, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt Awaiting requested review from davidhewitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add supported CPython/PyPy versions to cargo package metadata
2 participants
@messense @davidhewitt