Skip to content

Commit

Permalink
InMobi: mtype support (prebid#3921) (#967)
Browse files Browse the repository at this point in the history
  • Loading branch information
pm-saurabh-narkhede authored Nov 26, 2024
1 parent d68a113 commit 27966af
Show file tree
Hide file tree
Showing 8 changed files with 130 additions and 19 deletions.
28 changes: 15 additions & 13 deletions adapters/inmobi/inmobi.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,10 @@ func (a *InMobiAdapter) MakeBids(internalRequest *openrtb2.BidRequest, externalR

for _, sb := range serverBidResponse.SeatBid {
for i := range sb.Bid {
mediaType := getMediaTypeForImp(sb.Bid[i].ImpID, internalRequest.Imp)
mediaType, err := getMediaTypeForImp(sb.Bid[i])
if err != nil {
return nil, []error{err}
}
bidResponse.Bids = append(bidResponse.Bids, &adapters.TypedBid{
Bid: &sb.Bid[i],
BidType: mediaType,
Expand Down Expand Up @@ -118,18 +121,17 @@ func preprocess(imp *openrtb2.Imp) error {
return nil
}

func getMediaTypeForImp(impId string, imps []openrtb2.Imp) openrtb_ext.BidType {
mediaType := openrtb_ext.BidTypeBanner
for _, imp := range imps {
if imp.ID == impId {
if imp.Video != nil {
mediaType = openrtb_ext.BidTypeVideo
}
if imp.Native != nil {
mediaType = openrtb_ext.BidTypeNative
}
break
func getMediaTypeForImp(bid openrtb2.Bid) (openrtb_ext.BidType, error) {
switch bid.MType {
case openrtb2.MarkupBanner:
return openrtb_ext.BidTypeBanner, nil
case openrtb2.MarkupVideo:
return openrtb_ext.BidTypeVideo, nil
case openrtb2.MarkupNative:
return openrtb_ext.BidTypeNative, nil
default:
return "", &errortypes.BadServerResponse{
Message: fmt.Sprintf("Unsupported mtype %d for bid %s", bid.MType, bid.ID),
}
}
return mediaType
}
4 changes: 3 additions & 1 deletion adapters/inmobi/inmobitest/exemplary/simple-app-banner.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@
"price": 2.0,
"id": "1234",
"adm": "bannerhtml",
"impid": "imp-id"
"impid": "imp-id",
"mtype": 1
}
]
}
Expand All @@ -94,6 +95,7 @@
"adm": "bannerhtml",
"crid": "123456789",
"nurl": "https://some.event.url/params",
"mtype": 1,
"ext": {
"prebid": {
"meta": {
Expand Down
4 changes: 3 additions & 1 deletion adapters/inmobi/inmobitest/exemplary/simple-app-native.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@
"price": 2.0,
"id": "1234",
"adm": "native-json",
"impid": "imp-id"
"impid": "imp-id",
"mtype": 4
}
]
}
Expand All @@ -92,6 +93,7 @@
"adm": "native-json",
"crid": "123456789",
"nurl": "https://some.event.url/params",
"mtype": 4,
"ext": {
"prebid": {
"meta": {
Expand Down
4 changes: 3 additions & 1 deletion adapters/inmobi/inmobitest/exemplary/simple-app-video.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@
"price": 2.0,
"id": "1234",
"adm": "<?xml version=\"1.0\" encoding=\"UTF-8\"?> <VAST version=\"3.0\"></VAST>",
"impid": "imp-id"
"impid": "imp-id",
"mtype": 2
}
]
}
Expand All @@ -96,6 +97,7 @@
"adm": "<?xml version=\"1.0\" encoding=\"UTF-8\"?> <VAST version=\"3.0\"></VAST>",
"crid": "123456789",
"nurl": "https://some.event.url/params",
"mtype": 2,
"ext": {
"prebid": {
"meta": {
Expand Down
4 changes: 3 additions & 1 deletion adapters/inmobi/inmobitest/exemplary/simple-web-banner.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@
"price": 2.0,
"id": "1234",
"adm": "bannerhtml",
"impid": "imp-id"
"impid": "imp-id",
"mtype": 1
}
]
}
Expand All @@ -92,6 +93,7 @@
"adm": "bannerhtml",
"crid": "123456789",
"nurl": "https://some.event.url/params",
"mtype": 1,
"ext": {
"prebid": {
"meta": {
Expand Down
4 changes: 3 additions & 1 deletion adapters/inmobi/inmobitest/exemplary/simple-web-video.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@
"price": 2.0,
"id": "1234",
"adm": "<?xml version=\"1.0\" encoding=\"UTF-8\"?> <VAST version=\"3.0\"></VAST>",
"impid": "imp-id"
"impid": "imp-id",
"mtype": 2
}
]
}
Expand All @@ -94,6 +95,7 @@
"adm": "<?xml version=\"1.0\" encoding=\"UTF-8\"?> <VAST version=\"3.0\"></VAST>",
"crid": "123456789",
"nurl": "https://some.event.url/params",
"mtype": 2,
"ext": {
"prebid": {
"meta": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@
"price": 2.0,
"id": "1234",
"adm": "bannerhtml",
"impid": "imp-id"
"impid": "imp-id",
"mtype": 1
}
]
}
Expand All @@ -100,6 +101,7 @@
"adm": "bannerhtml",
"crid": "123456789",
"nurl": "https://some.event.url/params",
"mtype": 1,
"ext": {
"prebid": {
"meta": {
Expand Down
97 changes: 97 additions & 0 deletions adapters/inmobi/inmobitest/supplemental/invalid-mtype.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
{
"mockBidRequest": {
"site": {
"page": "https://www.inmobi.com"
},
"id": "req-id",
"device": {
"ip": "1.1.1.1",
"ua": "Mozilla/5.0 (Linux; Android 8.0.0; SM-G960F Build/R16NW) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.84 Mobile Safari/537.36"
},
"imp": [
{
"ext": {
"bidder": {
"plc": "1621323101291"
}
},
"video": {
"w": 640,
"h": 360,
"mimes": ["video/mp4"]
},
"id": "imp-id"
}
]
},
"httpCalls": [{
"expectedRequest": {
"uri": "https://api.w.inmobi.com/showad/openrtb/bidder/prebid",
"body": {
"site": {
"page": "https://www.inmobi.com"
},
"id": "req-id",
"device": {
"ip": "1.1.1.1",
"ua": "Mozilla/5.0 (Linux; Android 8.0.0; SM-G960F Build/R16NW) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.84 Mobile Safari/537.36"
},
"imp": [
{
"ext": {
"bidder": {
"plc": "1621323101291"
}
},
"video": {
"w": 640,
"h": 360,
"mimes": ["video/mp4"]
},
"id": "imp-id"
}
]
},
"impIDs":["imp-id"]
},
"mockResponse": {
"status": 200,
"body": {
"id": "req-id",
"seatbid": [
{
"bid": [
{
"ext": {
"prebid": {
"meta": {
"networkName": "inmobi"
}
}
},
"nurl": "https://some.event.url/params",
"crid": "123456789",
"adomain": [],
"price": 2.0,
"id": "1234",
"adm": "<?xml version=\"1.0\" encoding=\"UTF-8\"?> <VAST version=\"3.0\"></VAST>",
"impid": "imp-id",
"mtype": 0
}
]
}
]
}
}
}],

"expectedBidResponses":[],
"expectedMakeBidsErrors":[
{
"value":"Unsupported mtype 0 for bid 1234",
"comparison":"literal"
}
]
}


0 comments on commit 27966af

Please sign in to comment.