Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panorama broken since 729b946 #121

Closed
gangelop opened this issue Sep 17, 2020 · 1 comment
Closed

panorama broken since 729b946 #121

gangelop opened this issue Sep 17, 2020 · 1 comment

Comments

@gangelop
Copy link
Contributor

panorama broken since 729b946

Currently in master at 0c6e83f build exits successfully but render fails in browser with console output:

jquery.min.js:2 Uncaught TypeError: e.indexOf is not a function
    at k.fn.init.k.fn.load (jquery.min.js:2)
    at HTMLElement.<anonymous> (jquery.panorama_viewer.min.js:1)
    at Function.each (jquery.min.js:2)
    at k.fn.init.each (jquery.min.js:2)
    at k.fn.init.e.fn.panorama_viewer (jquery.panorama_viewer.min.js:1)
    at (index):82
k.fn.load @ jquery.min.js:2
(anonymous) @ jquery.panorama_viewer.min.js:1
each @ jquery.min.js:2
each @ jquery.min.js:2
e.fn.panorama_viewer @ jquery.panorama_viewer.min.js:1
(anonymous) @ (index):82

Might investigate further but I've never touched jQuery before.
@QSchulz
Copy link
Contributor

QSchulz commented Oct 10, 2020

See: peachananr/panorama_viewer#19 (comment) for how to fix this issue.

Considering this JS script hasn't seen any code update in the last 6 years and a half, maybe it'd be time to actually swap to something more recent?

QSchulz added a commit to QSchulz/prosopopee that referenced this issue Oct 18, 2020
@QSchulz
themes: js: panorama_viewer: fix panorama
e4f8d14 
Taken from
peachananr/panorama_viewer#19 (comment).

This fixes Psycojoker#121.

Signed-off-by: Quentin Schulz <[email protected]>
@QSchulz QSchulz mentioned this issue Oct 18, 2020
Merged
Psycojoker pushed a commit that referenced this issue Jan 31, 2021
@QSchulz @Psycojoker
themes: js: panorama_viewer: fix panorama
0be8bf7 
Taken from
peachananr/panorama_viewer#19 (comment).

This fixes #121.

Signed-off-by: Quentin Schulz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gangelop @QSchulz