Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Implemented Skinning #167

Merged
merged 22 commits into from
Feb 17, 2020
Merged

Implemented Skinning #167

merged 22 commits into from
Feb 17, 2020

Conversation

sunjay
Copy link
Contributor

@sunjay sunjay commented Feb 17, 2020

Fixes #24.

This PR implements skinning. Skinning is a major feature that moves us closer to fully supporting skeletal animation. The last step to supporting that is for @JLSJamesShi to finish #18.

Before/after shots of bigboi:

without skinning with skinning

I also added some simpler test models to help with testing/debugging:

  • A model without any rigging data whatsoever:
    alien_ghost
  • A model with a very simple rig and little geometry:
    posed_arm

References

@sunjay sunjay requested a review from a team February 17, 2020 00:16
daose
daose approved these changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@daose daose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay full speed ahead for no-more-t-poses

sunjay added 22 commits February 16, 2020 19:38
@sunjay
Extracting joint_influences and weights from glTF geometry
a1632d9
@sunjay
Replaced hierarchical node structure with de-duplicated adjacency-lis…
6a4711d 
…t based representation
@sunjay
Setup code to start loading skin data
d435c48
@sunjay
Loading in skin data
c73bd03
@sunjay
No longer exposing internal implementation details of node tree
0f8db19
@sunjay
Adding joint_influences and joint_weights to ShaderGeometry
7735587
@sunjay
Adding joint_influences and joint_weights to the attributes used when…
c622992 
… rendering
@sunjay
New alien ghost character for testing with no rigging data
cb0956d
@sunjay
Computing joint matrices and exposing them through a texture
f1c9a00
@sunjay
Generating joint matrix textures and passing them to the shader
89c78ed
@sunjay
Removed branching from the shader and premultiplied model_transform i…
8a3e9ef 
…nstead
@sunjay
New posed_arm sample for testing rigging without animation
43861d7
@sunjay
Need to multiply gl_Position by skin matrix too
e0d4367
@sunjay
Fixed incorrect indexing into joint matrix texture
d41d942
@sunjay
Simplified posed_arm model for testing
ea1255a
@sunjay
Revert "Simplified posed_arm model for testing"
ac2744c 
This reverts commit a8e885b.
@sunjay
Need to specify data format or OpenGL will change the data in the tex…
b0f6583 
…ture
@sunjay
Applying skinning calculations to outline shader
9180a92
@sunjay
Some useful debugging code (commented out)
f184af4
@sunjay
Revert "Some useful debugging code (commented out)"
d03572a 
This reverts commit d86e50c.
@sunjay
Caching the default joint matrix
48bda4a
@sunjay
Caching the joint matrix texture since OBJ always uses the same one (…
2c1662b 
…the default)
@sunjay sunjay merged commit 2bd849b into master Feb 17, 2020
@sunjay sunjay deleted the skins branch February 17, 2020 00:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daose daose daose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support glTF Skinning for Skeletal Animation
2 participants
@sunjay @daose