Expect zero value for opacity and index in OpenSeadragonTileSource #4037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeer
reviewed
Dec 13, 2024
cbeer
reviewed
Dec 13, 2024
cbeer
force-pushed
the
osd-tilesource-compare-to-undefined
branch
from
6358aaa to
a9c8da7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opacityandindexmight be0, so!opacityand!indexmight skip necessary changes. You can see the effect if you try hiding a layer from the Layers demo:https://deploy-preview-3991--mirador-dev.netlify.app/__tests__/integration/mirador/layers.html
(Or maybe try a more simple manifest like https://iiif.io/api/cookbook/recipe/0036-composition-from-multiple-images/manifest.json .)