Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow user to pass initalViewerConfig into windows #4019

Merged
merged 1 commit into from
Dec 9, 2024
Merged

allow user to pass initalViewerConfig into windows #4019

merged 1 commit into from
Dec 9, 2024

Conversation

cbeer
Copy link
Collaborator

@cbeer cbeer commented Dec 6, 2024

Rebases #4011

marlo-longley
marlo-longley previously approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@marlo-longley marlo-longley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works locally

@dnoneill
Copy link
Collaborator

dnoneill commented Dec 6, 2024 •
edited
Loading

I don't see where initialViewerState gets loaded. nevermind. I see it is getting loaded as part of the action.

@dnoneill
Copy link
Collaborator

dnoneill commented Dec 6, 2024

Works for me locally as well. Is this ready for merge?

@marlo-longley marlo-longley merged commit 126a357 into master Dec 9, 2024
7 of 8 checks passed
@marlo-longley marlo-longley deleted the viewer-state branch December 9, 2024 22:04
@cbeer cbeer mentioned this pull request Dec 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marlo-longley marlo-longley marlo-longley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbeer @dnoneill @marlo-longley