Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the useContext hook instead of withWorkspaceContext HOC #4018

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

cbeer
Copy link
Collaborator

@cbeer cbeer commented Dec 5, 2024

No description provided.

@cbeer cbeer force-pushed the workspace-context-context branch from 66b61ee to c13ffc5 Compare December 6, 2024 16:51
marlo-longley
marlo-longley previously approved these changes Dec 6, 2024
Copy link
Member

@marlo-longley marlo-longley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Much cleaner. Looks good!

@marlo-longley marlo-longley dismissed their stale review December 6, 2024 17:19

Didn't see linter error

Copy link
Member

@marlo-longley marlo-longley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is one more error in:

mirador/src/components/WorkspaceOptionsMenu.js
  19:32  error  'WorkspaceContext' is not defined  no-undef

@cbeer cbeer force-pushed the workspace-context-context branch from c13ffc5 to b987a38 Compare December 6, 2024 17:28
@cbeer cbeer requested a review from marlo-longley December 6, 2024 17:28
@marlo-longley marlo-longley merged commit 7a32c14 into master Dec 6, 2024
8 checks passed
@marlo-longley marlo-longley deleted the workspace-context-context branch December 6, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants